Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Added additional tests for pip_parse and pip_install utilties #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2021
Merged

Added additional tests for pip_parse and pip_install utilties #524

merged 1 commit into from
Oct 1, 2021

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Sep 6, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

To close the loop on #519 (comment), tests have been added for the data_requirement and dist_info_requirement utilities of pip_parse and pip_install.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Sep 6, 2021
@UebelAndre
Copy link
Contributor Author

The tests here make use of py_test::env which was released in Bazel 4.0.0. The min tested version will need to be raised (392d320).

@UebelAndre
Copy link
Contributor Author

UebelAndre commented Sep 6, 2021 •
edited
Loading

This PR is blocked by #526 as it'd probably make sense to do 392d320 in a separate PR.

@UebelAndre UebelAndre mentioned this pull request Sep 7, 2021
Merged
13 tasks
alexeagle
alexeagle reviewed Sep 12, 2021
View reviewed changes
.bazelversion Outdated Show resolved Hide resolved
@UebelAndre
Copy link
Contributor Author

This PR is now unblocked and ready for another review.

@alexeagle alexeagle merged commit 8e2b6de into bazel-contrib:main Oct 1, 2021
@UebelAndre UebelAndre deleted the test branch October 1, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@andyscott andyscott Awaiting requested review from andyscott

@thundergolfer thundergolfer Awaiting requested review from thundergolfer

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @alexeagle
Morty Proxy This is a proxified and sanitized view of the page, visit original site.