Add a better error message when deps not found #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the skylark `fail` function instead of letting Python throw a key-not-found exception.
|
Can one of the admins verify this patch? |
|
Please test this |
mattmoor
approved these changes
Nov 15, 2017
| return _requirements[name] | ||
| name_key = name.replace("-", "_").lower() | ||
| if name_key not in _requirements: | ||
| fail("Could not find pip-provided dependency: '%s'" % name) |
There was a problem hiding this comment.
Maybe it would be interesting to include what's available?
There was a problem hiding this comment.
We could, but since that list is unbounded, I'm concerned that it would be too much for this error string.
There was a problem hiding this comment.
This is Python, not Node.js ;-)
SGTM
|
Test this please |
alexeagle
pushed a commit
to alexeagle/rules_python
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the skylark
failfunction instead of letting Python throw akey-not-found exception.
(There may be a prettier way of doing this: I'm happy to be shown
differently, or to bikeshed the prose.)