Merge rules_python_external #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-from-rules-pip
…namespace_pkgs module where it really belongs
This is the beginning of making that the canonical way to get dependencies, replacing the pip features in this repo. Our plan is in multiple steps: - (this PR) bring in the repo to a subdirectory, preserving git history and contributors - clean up the code, remove mypy, get it functional in that subdirectory - add an example/integration test proving that it works - cut a patch release and get some users to test it out - communicate our deprecation plan to rules_python users - BIG SWITCH: move the rules_python_external implementation to the root, make a legacy/ directory for current impl - fill in any missing docstrings and include new rules in stardoc - cut a breaking release (a minor, since semver starting with 0. states that minors are breaking) - help users switch over - in a later breaking release, actually remove the old implementation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Paper trail for CLAs: this is a pure roll-forward of #348 where we had all the authors consent to their code being merged into this repo. |
8296fcf to
ed0686c
Compare
Just enough to get CI green for now Also ignore the merge commit in git blame and the subdirectory when expanding //... pattern
ed0686c to
1d5d724
Compare
thundergolfer
approved these changes
Aug 26, 2020
alexeagle
pushed a commit
to alexeagle/rules_python
that referenced
this pull request
Aug 29, 2020
- Clean up files that aren't needed now that it's a subdirectory of rules_python - Move the example into the top-level examples From the checklist in bazel-contrib#352 this is the third item.
alexeagle
pushed a commit
to alexeagle/rules_python
that referenced
this pull request
Aug 29, 2020
- Clean up files that aren't needed now that it's a subdirectory of rules_python - Move the example into the top-level examples From the checklist in bazel-contrib#352 this is the third item.
alexeagle
pushed a commit
to alexeagle/rules_python
that referenced
this pull request
Aug 31, 2020
- Clean up files that aren't needed now that it's a subdirectory of rules_python - Move the example into the top-level examples From the checklist in bazel-contrib#352 this is the third item.
alexeagle
added a commit
that referenced
this pull request
Aug 31, 2020
- Clean up files that aren't needed now that it's a subdirectory of rules_python - Move the example into the top-level examples From the checklist in #352 this is the third item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of making that the canonical way to get dependencies, replacing the pip features in this repo.
Our plan is in multiple steps:
This is a second pass at this PR since the first one got squashed