-
-
Notifications
You must be signed in to change notification settings - Fork 598
Upgrade to setuptools==44.0.0 #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This allows new features in setuptools, like find_namespace_packages.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Where do these binaries come from? I'm reluctant to merge some random binary blob. |
https://github.com/bazelbuild/rules_python/blob/master/update_tools.sh
Generated them. I used the default (docker).
lberki <notifications@github.com> 于 2020年3月3日周二 00:25写道:
… Where do these binaries come from? I'm reluctant to merge some random
binary blob.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#285>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOOSKCSHFQ4DBNNO6RL4OJTRFS5GBANCNFSM4K76WUVA>
.
|
Erm, sorry for being somewhat dense. I'll regenerate the binary blobs them and will merge this pull request instead: |
Rebuilt the binaries, checksum matches (see #286). Will merge! |
Thanks Lukács. For reference we always regenerate the par files before merging. |
This allows new features in setuptools, like find_namespace_packages.