Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Upgrade to setuptools==44.0.0 #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Conversation

XingChenKolmostar
Copy link
Contributor

This allows new features in setuptools, like find_namespace_packages.

This allows new features in setuptools, like find_namespace_packages.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@XingChenKolmostar
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 3, 2020
@lberki
Copy link
Contributor

lberki commented Mar 3, 2020

Where do these binaries come from? I'm reluctant to merge some random binary blob.

@XingChenKolmostar
Copy link
Contributor Author

XingChenKolmostar commented Mar 3, 2020 via email

@lberki
Copy link
Contributor

lberki commented Mar 3, 2020

Erm, sorry for being somewhat dense. I'll regenerate the binary blobs them and will merge this pull request instead:

#286

@lberki
Copy link
Contributor

lberki commented Mar 3, 2020

Rebuilt the binaries, checksum matches (see #286). Will merge!

@lberki lberki removed the request for review from brandjon March 3, 2020 08:59
@lberki lberki merged commit 17dba4b into bazel-contrib:master Mar 3, 2020
@brandjon
Copy link
Contributor

brandjon commented Mar 4, 2020

Thanks Lukács. For reference we always regenerate the par files before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.