Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

README improvements #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2019
Merged

README improvements #239

merged 3 commits into from
Oct 18, 2019

Conversation

brandjon
Copy link
Contributor

Follow-up to #237. Moves development workflow info to CONTRIBUTING.md. Fixes
the instructions for how to use the Bazel Federation.

Also updates the project WORKSPACE to use a released version of the Federation.

Follow-up to bazel-contrib#237. Moves development workflow info to CONTRIBUTING.md. Fixes
the instructions for how to use the Bazel Federation.

Also updates the project WORKSPACE to use a released version of the Federation.
@brandjon brandjon requested review from laurentlb and aiuto October 10, 2019 18:53
@brandjon brandjon requested a review from lberki as a code owner October 10, 2019 18:53
@brandjon brandjon self-assigned this Oct 10, 2019
@brandjon brandjon mentioned this pull request Oct 10, 2019
@brandjon brandjon removed the request for review from lberki October 10, 2019 18:54
@brandjon
Copy link
Contributor Author

Ping @laurentlb

@brandjon brandjon requested a review from fweikert October 17, 2019 18:04
@brandjon
Copy link
Contributor Author

Adding @fweikert since aiuto is on vacation. Florian, this is just a readme update that happens to include some fixes for the federation, so I figured you could vet the federation content ("Getting started" section) and rubber stamp the rest.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fweikert fweikert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the federation-related parts

@brandjon
Copy link
Contributor Author

I'll merge this. Laurent, feel free to request changes in a follow-up.

@brandjon brandjon merged commit f46e953 into bazel-contrib:master Oct 18, 2019
@brandjon brandjon deleted the readmework branch October 18, 2019 15:17
@laurentlb
Copy link
Contributor

Thanks!
(sorry for the delay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.