Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix extra dependencies #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

ptarjan
Copy link
Contributor

@ptarjan ptarjan commented Jul 24, 2019

This will remove duplicate dependencies. Without this patch we are seeing errors like:

Label '@pypi__enum34_1_1_6//:pkg' is duplicated in the 'deps' attribute of rule 'pkg'

@ptarjan ptarjan force-pushed the fix-extra-dependencies branch from d471f9a to 0b26519 Compare July 29, 2019 18:35
@ptarjan
Copy link
Contributor Author

ptarjan commented Jul 29, 2019

@brandjon gentle ping

@laurentlb laurentlb requested review from brandjon and lberki July 31, 2019 16:59
@brandjon brandjon force-pushed the fix-extra-dependencies branch from 91bd352 to 9787fdb Compare August 2, 2019 14:00
@brandjon
Copy link
Contributor

brandjon commented Aug 2, 2019

Regenerated the par files, rebased, and pushed to your branch. Merging momentarily.

@brandjon brandjon merged commit 04fae2a into bazel-contrib:master Aug 2, 2019
fweikert pushed a commit to fweikert/rules_python that referenced this pull request Aug 7, 2019
Remove duplicate dependencies to avoid errors in deps attribute, and regenerate the .par files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.