Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

pin upstream bazel to 0.24 #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Conversation

ptarjan
Copy link
Contributor

@ptarjan ptarjan commented Jul 24, 2019

Fixes: #208
It looks like you just reference the latest bazel, which means your builds will just break on bazel releases. Instead I suggest pinning to a certain version and then you can walk the version up at your leisure without master sitting there broken.

@brandjon
Copy link
Contributor

Thanks! Pinning the bazel version is probably a good idea even if we want to keep compatibility with the bleeding edge. Will merge later today.

@brandjon brandjon self-assigned this Jul 25, 2019
@brandjon brandjon self-requested a review July 25, 2019 13:54
@brandjon
Copy link
Contributor

Thinking about this more, I don't think we need to change from the apt repo to wgetting the install script. It looks like old versions are not pruned from the bazel-apt package source, so that should still be viable, plus it avoids needing to manually install dependencies (beyond openjdk, as described on the install page).

I'll see if pinning it in the install line works, then maybe refactor this file a bit.

@brandjon
Copy link
Contributor

Turns out we don't keep old versions around in our apt repo after all, despite the fact that the files themselves are still present and reported in the XML page at the apt's URL. Oh well.

The other options someone suggested were

  • wgetting the binary and running it directly without installation, or

  • using bazelisk

I think your approach is simpler.

@brandjon brandjon merged commit 08ba1d6 into bazel-contrib:master Jul 25, 2019
fweikert pushed a commit to fweikert/rules_python that referenced this pull request Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow for regenerating par files is broken
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.