Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Split on more characters when stripping the version metadata. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2017

Conversation

mattmoor
Copy link
Contributor

@mattmoor mattmoor commented Oct 4, 2017

boto3s metadata.json file doesn't delimit the version specifier the way other packages I've come across seem to, so support splitting on the kinds of characters this variation might foist upon us.

Fixes: #20

`boto3`s `metadata.json` file doesn't delimit the version specifier the way other packages I've come across seem to, so support splitting on the kinds of characters this variation might foist upon us.

Fixes: bazel-contrib#20
@mattmoor mattmoor requested a review from damienmg October 4, 2017 17:37
@mattmoor
Copy link
Contributor Author

mattmoor commented Oct 4, 2017

@damienmg Can you review? @duggelz is out of the office.

@damienmg
Copy link

damienmg commented Oct 4, 2017

No tests?

@mattmoor
Copy link
Contributor Author

mattmoor commented Oct 4, 2017

@damienmg boto_test.py is the test. I want to make sure we can build and import it, by the time that happens I've covered what I want :)

Copy link

@damienmg damienmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I see :)

@mattmoor mattmoor merged commit 44fdf5f into bazel-contrib:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.