Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat(gazelle): support multiple requirements files in manifest generation #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Jul 10, 2023

For certain workflows it is useful to calculate the integrity hash of
the manifest file based on a number of requirements files. The
requirements locking is usually done by executing a script on each
platform and having gazelle manifest generator be aware that more than
one requirements file may affect the outcome (e.g. the wheels that get
passed to modules map may come from multi_pip_parse rule) is generally
useful.

This change modifies the generation macro to concatenate the requirements
files into one before passing it to the manifest generator.

@aignas
Copy link
Collaborator Author

aignas commented Jul 10, 2023

Supersedes #1235.

@aignas aignas marked this pull request as ready for review July 10, 2023 03:05
@aignas aignas requested review from f0rmiga and rickeylev as code owners July 10, 2023 03:05
@f0rmiga f0rmiga added this pull request to the merge queue Jul 10, 2023
Merged via the queue into bazel-contrib:main with commit 9dd944e Jul 10, 2023
@aignas aignas deleted the feat/gazelle-support-multiple-requirements-files branch May 13, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.