Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

cleanup: Typos, doc, and formatting cleanup in pip extension et al #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2023
Merged

cleanup: Typos, doc, and formatting cleanup in pip extension et al #1275

merged 4 commits into from
Jun 20, 2023

Conversation

rickeylev
Copy link
Collaborator

  • Corrects some typos in docs
  • Expands the user-facing documentation
  • Fixes errors having newlines in the middle of them
  • Renames some internal functions to be more self-describing.

@rickeylev
cleanup: Typos, doc, and formatting cleanup in pip extension et al
fc53fae 
* Corrects some typos in docs
* Expands the user-facing documentation
* Fixes errors having newlines in the middle of them
* Renames some internal functions to be more self-describing.
@rickeylev rickeylev requested a review from chrislovecnm June 15, 2023 22:46
@rickeylev rickeylev requested a review from hrfuller as a code owner June 15, 2023 22:46
chrislovecnm
chrislovecnm suggested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More word smithing requested.

python/extensions/pip.bzl Show resolved Hide resolved
python/extensions/pip.bzl Outdated Show resolved Hide resolved
python/extensions/pip.bzl Outdated Show resolved Hide resolved
python/extensions/pip.bzl Outdated Show resolved Hide resolved
python/extensions/pip.bzl Outdated Show resolved Hide resolved
rickeylev
rickeylev commented Jun 20, 2023
View reviewed changes
Copy link
Collaborator Author

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptal

python/extensions/pip.bzl Outdated Show resolved Hide resolved
python/extensions/pip.bzl Outdated Show resolved Hide resolved
python/extensions/pip.bzl Outdated Show resolved Hide resolved
python/extensions/pip.bzl Outdated Show resolved Hide resolved
chrislovecnm
chrislovecnm approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrislovecnm chrislovecnm enabled auto-merge June 20, 2023 19:57
@chrislovecnm chrislovecnm added this pull request to the merge queue Jun 20, 2023
Merged via the queue into bazel-contrib:main with commit cc43594 Jun 20, 2023
@rickeylev rickeylev deleted the multi.pip.tidying branch June 20, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

@hrfuller hrfuller Awaiting requested review from hrfuller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickeylev @chrislovecnm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.