Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

pip_install doesn't treat python_version correctly for Python 3.10+ #468

Copy link
Copy link
Closed
@stdbug

Description

@stdbug
Issue body actions

Description

pip_install doesn't treat python_version correctly for Python 3.10+

🔬 Minimal Reproduction

Try installing "asgiref=3.3.4" pip dependency via pip_install with python having version >= 3.10
asgiref's METADATA mentions requirement for typing-extnensions:

Requires-Dist: typing-extensions ; python_version < "3.8"

🔥 Exception or Error

BUILD file not found in directory 'pypi__typing_extensions' of external repository @workspace_name.

🌍 Your Environment

Debian 10
bazel 4.0.0
Rules_python version: both 2.0 and current master

Anything else relevant?

It seems like an issue is in line 53 of wheel.py where it should be or [] instead of or [""], but I don't have a holistic understanding of rules_python, so no PR, just a bug

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.