Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Allow customizing DEFAULT_PACKAGE_PREFIX in pip_parse #450

Copy link
Copy link
Closed
@person142

Description

@person142
Issue body actions

🚀 feature request

Relevant Rules

pip_parse

Description

Related to #414.

In the old pip_install the generated repository was of the form

<repo>/pypi__<sanitized-name>/...

with pip_parse it's

<repo>_pypi__<sanitized-name>/...

I'd like to be able to customize the pypi__ prefix (in particular making it "", so that the repositories are of the form <repo>_<sanitized-name>, which is easy to remember and type if you're say invoking an aspect against a requirement.) For pip_install it's not straightforward because of #414 (comment), but for pip_parse there's no problem.

Describe the solution you'd like

Make the default prefix here:

https://github.com/bazelbuild/rules_python/blob/master/python/pip_install/extract_wheels/lib/bazel.py#L107

configurable by an argument to the rule. Happy to make this change if deemed acceptable.

Describe alternatives you've considered

Live with the status quo.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.