Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: enable pipstar by default #2949

Copy link
Copy link
Open
Copy link
@aignas

Description

@aignas
Issue body actions

This is just a laundry list for the flag to be flipped by default and enable better dependency graph construction using the marker settings.

  • Add expressions_any to the env_marker_setting macro so that we can create many targets under the hood so that each FeatureFlagInfo producing target would be processing smaller expressions. At the moment we just do (expr1) or (expr2) or ... combination, which feel like it may make the tokenizing more nested and we cannot short-circuit early unless we improve the parser.
  • Wait for the Improve the pip.parse API to allow for incremental building of the configuration #2747 to be finished so that users can have levers to pull to configure the env marker evaluation when parsing requirements files.
  • Enable pipstar by default in rules_python CI
  • Ask users to test pipstar in isolation before the next release.
  • (optional) add an example in the documentation how to configure platform_version and similar?

Am I missing some steps?

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: pippip/pypi integrationpip/pypi integration

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.