Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bdcf53a

Browse filesBrowse files
tokongsaignas
andauthored
fix: formatting directive bugs in test (#2134)
I'm getting a build error in my builds because nogo complains about this bug. I guess I could configure my nogo to no check this code, but I think it should be fixed. --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
1 parent d7d2ce7 commit bdcf53a
Copy full SHA for bdcf53a

File tree

Expand file treeCollapse file tree

2 files changed

+6
-3
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+6
-3
lines changed

‎CHANGELOG.md

Copy file name to clipboardExpand all lines: CHANGELOG.md
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ A brief description of the categories of changes:
2727
### Changed
2828
* Nothing yet
2929

30+
### Fixed
31+
* (gazelle): Fix incorrect use of `t.Fatal`/`t.Fatalf` in tests.
32+
3033
### Added
3134
* Nothing yet
3235

‎gazelle/manifest/test/test.go

Copy file name to clipboardExpand all lines: gazelle/manifest/test/test.go
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ import (
3333
func TestGazelleManifestIsUpdated(t *testing.T) {
3434
requirementsPath := os.Getenv("_TEST_REQUIREMENTS")
3535
if requirementsPath == "" {
36-
t.Fatalf("_TEST_REQUIREMENTS must be set")
36+
t.Fatal("_TEST_REQUIREMENTS must be set")
3737
}
3838

3939
manifestPath := os.Getenv("_TEST_MANIFEST")
4040
if manifestPath == "" {
41-
t.Fatalf("_TEST_MANIFEST must be set")
41+
t.Fatal("_TEST_MANIFEST must be set")
4242
}
4343

4444
manifestFile := new(manifest.File)
@@ -53,7 +53,7 @@ func TestGazelleManifestIsUpdated(t *testing.T) {
5353
manifestGeneratorHashPath, err := runfiles.Rlocation(
5454
os.Getenv("_TEST_MANIFEST_GENERATOR_HASH"))
5555
if err != nil {
56-
t.Fatal("failed to resolve runfiles path of manifest: %v", err)
56+
t.Fatalf("failed to resolve runfiles path of manifest: %v", err)
5757
}
5858

5959
manifestGeneratorHash, err := os.Open(manifestGeneratorHashPath)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.