Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6433080

Browse filesBrowse files
committed
fix(gazelle): Only generate test target if there is a test file or a test target
1 parent 932ec5f commit 6433080
Copy full SHA for 6433080

File tree

Expand file treeCollapse file tree

2 files changed

+16
-19
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+16
-19
lines changed

‎gazelle/python/generate.go

Copy file name to clipboardExpand all lines: gazelle/python/generate.go
+15-13Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -393,20 +393,22 @@ func (py *Python) GenerateRules(args language.GenerateArgs) language.GenerateRes
393393
// the file exists on disk.
394394
pyTestFilenames.Add(pyTestEntrypointFilename)
395395
}
396-
pyTestTargetName := cfg.RenderTestName(packageName)
397-
pyTestTarget := newPyTestTargetBuilder(pyTestFilenames, pyTestTargetName)
398-
399-
if hasPyTestEntryPointTarget {
400-
entrypointTarget := fmt.Sprintf(":%s", pyTestEntrypointTargetname)
401-
main := fmt.Sprintf(":%s", pyTestEntrypointFilename)
402-
pyTestTarget.
403-
addSrc(entrypointTarget).
404-
addResolvedDependency(entrypointTarget).
405-
setMain(main)
406-
} else {
407-
pyTestTarget.setMain(pyTestEntrypointFilename)
396+
if (hasPyTestEntryPointTarget || !pyTestFilenames.Empty()) {
397+
pyTestTargetName := cfg.RenderTestName(packageName)
398+
pyTestTarget := newPyTestTargetBuilder(pyTestFilenames, pyTestTargetName)
399+
400+
if hasPyTestEntryPointTarget {
401+
entrypointTarget := fmt.Sprintf(":%s", pyTestEntrypointTargetname)
402+
main := fmt.Sprintf(":%s", pyTestEntrypointFilename)
403+
pyTestTarget.
404+
addSrc(entrypointTarget).
405+
addResolvedDependency(entrypointTarget).
406+
setMain(main)
407+
} else {
408+
pyTestTarget.setMain(pyTestEntrypointFilename)
409+
}
410+
pyTestTargets = append(pyTestTargets, pyTestTarget)
408411
}
409-
pyTestTargets = append(pyTestTargets, pyTestTarget)
410412
} else {
411413
// Create one py_test target per file
412414
pyTestFilenames.Each(func(index int, testFile interface{}) {
+1-6Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@rules_python//python:defs.bzl", "py_library", "py_test")
1+
load("@rules_python//python:defs.bzl", "py_library")
22

33
# gazelle:python_extension enabled
44
# gazelle:python_generation_mode project
@@ -8,8 +8,3 @@ py_library(
88
srcs = ["__init__.py"],
99
visibility = ["//:__subpackages__"],
1010
)
11-
12-
py_test(
13-
name = "project_generation_mode_test",
14-
main = "__test__.py",
15-
)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.