Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 1226caa

Browse filesBrowse files
keithkeith
authored
Add error for pip.parse attrs that require other attrs (#2646)
This makes it more clear when you've misconfigured pip.parse
1 parent f4fde65 commit 1226caa
Copy full SHA for 1226caa

File tree

Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed

‎python/private/pypi/extension.bzl

Copy file name to clipboardExpand all lines: python/private/pypi/extension.bzl
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -481,6 +481,10 @@ You cannot use both the additive_build_content and additive_build_content_file a
481481
cache = simpleapi_cache,
482482
parallel_download = pip_attr.parallel_download,
483483
)
484+
elif pip_attr.experimental_extra_index_urls:
485+
fail("'experimental_extra_index_urls' is a no-op unless 'experimental_index_url' is set")
486+
elif pip_attr.experimental_index_url_overrides:
487+
fail("'experimental_index_url_overrides' is a no-op unless 'experimental_index_url' is set")
484488

485489
out = _create_whl_repos(
486490
module_ctx,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.