Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: basilisp-lang/basilisp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.6
Choose a base ref
Loading
...
head repository: basilisp-lang/basilisp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.7
Choose a head ref
Loading
  • 4 commits
  • 15 files changed
  • 3 contributors

Commits on Feb 10, 2025

  1. fix testrunner to handle relative entries in sys.path (#1205)

    Hi,
    
    could you please review patch to fix a likely regression issue where the
    testrunner couldn't handle relative paths in `sys.path`. It fixes #1204.
    
    This is likely a regression from #1176, where the update to the new
    module loading system caused relative paths to never match a fully
    qualified module name. The patch now expands relative paths to their
    absolute form before comparing them to the module path.
    
    This issue was breaking the vanilla `basilisp test` command, as it adds
    an empty string (`""`) entry to `sys.path`, which is interpreted as
    `"."`. Since this is a relative path, it wasn’t handled by the logic,
    causing the project directory not to be recognized as the root of the
    Basilisp test modules.
    
    I’ve added a test that invokes `basilisp test` directly as a subprocess.
    Unfortunately, I couldn’t find a way to control the pytester `sys.path`
    entries with the precise control required for this test. Any counter
    suggestions are most welcome.
    
    Thanks
    
    ---------
    
    Co-authored-by: ikappaki <ikappaki@users.noreply.github.com>
    ikappaki and ikappaki authored Feb 10, 2025
    Configuration menu
    Copy the full SHA
    3194c85 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2025

  1. Configuration menu
    Copy the full SHA
    21c2642 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2025

  1. Pickup bootstrap site-packages location from sysconfig purelib path (#…

    …1211)
    
    Hi,
    
    could you please review patch to pickup the boostrap site-packages
    location from the `sysconfig` `purelib` path. It fixes #1208.
    
    The bootstrap options and code now operate on a single path instead of a
    list, likely because `getsitepackages` previously returned a list of
    paths, which is no longer relevant (unless there's another reason I'm
    missing).
    
    I've also updated the `bootstrap` command to print the file's creation
    path, which I find useful for awareness.
    
    For testing, I couldn't think of a case other than creating a virtual
    environment to test the `bootstrap` within it. I implemented a minimal
    solution using the `pytest_virtualenv` plugin, which provides a fixture
    for this. Since creating a Basilisp environment takes 20+ seconds, I
    added a pytest decorator to run it only on GitHub CI. Let me know if you
    have other testing suggestions or if it's better to leave this out
    altogether. I consider these type of tests as part of integration
    testing (which ideally run as a separate command/job), but we don't have
    that setup (yet?).
    
    Thanks
    
    ---------
    
    Co-authored-by: ikappaki <ikappaki@users.noreply.github.com>
    ikappaki and ikappaki authored Feb 21, 2025
    Configuration menu
    Copy the full SHA
    39b3707 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4a1ab99 View commit details
    Browse the repository at this point in the history
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.