Keyboard brightness multimedia keys support #2331
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use a 2019 macbook air and the keyboard keys for backlight do not work out of the box. Made a issues post and a discussion on it and got some feedback.
Adding my commit to the default media.conf could help with the out of the box experience.
Possible Issues:
my keyboard uses apple::kbd_backlight call. I have seen another person have a smc::kbd_backlight call. We could make the vendor into a variable and pass into it, but I do not know how to call it.
References:
#2291
#1779