Auto-detect icons and icon conversion support for webapp/tui install #2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Auto-detect icons from website URLs using Google's favicons service
Add ImageMagick conversion support for custom non-PNG icon URLs
Resolution for the auto-detected icons depends on what the website provides through favicons
Some websites may only offer low-resolution icons, but manifest/html parsing for higher quality icons was intentionally skipped to keep the implementation simple. It would add a lot of code and new problems like robot block with some site like e.g. facebook.
Here an overview how the auto-detected icons look like for some test sites. Most are pretty good.
Changes
Icon Auto-Detection
ImageMagick Icon Conversion
-flattenfor problematic formatsI also add https:// if no protocol specified for the url so the user can just type hey.com instead of https://hey.com