Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Bugfix/fix pull request for segmentation additions #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 55 commits into
base: master
Choose a base branch
Loading
from
Open

Bugfix/fix pull request for segmentation additions #974

wants to merge 55 commits into from

Conversation

skarg
Copy link
Collaborator

@skarg skarg commented Apr 26, 2025

No description provided.

Nathiya Ramasamy and others added 22 commits February 26, 2025 00:02
Segmentation feature for server
73c028e
@nathiyaramasamy
Merge branch 'bacnet-stack:master' into master
52ed764
Code fix for segmentation issues
bc06d85
@nathiyaramasamy
Merge branch 'bacnet-stack:master' into master
e97461b
Code update
7c480e7
@skarg
preserve backward compatibility for address_get_by_device() function.
f214434
@skarg
Added SEGMENT ACK PDU to MS/TP comparison
acfb226
@skarg
APDU cleanup from master branch
b2f7c67
@skarg
Adhere new defines to coding standard. Remove unused code.
5a4a74d
@skarg
Per 9.5.6.5 DONE_WITH_TOKEN SendToken transition: set RetryCount and …
baf8895 
…EventCount to zero;
@skarg
Simpify RP and RPM handlers. Fix warnings from non-segmented compilat…
e4ff9f5 
…ion.
@skarg
Use ifdef and unique namespace for Window Size define.
5862c3a
@skarg
Rename TSM API in module namespace.
c3b6568
@skarg
Changed function names to match module API namespace. Changed non-pub…
db2a6fe 
…lic function API to static scope.
@skarg
clang-format and pre-commit
48f1d93
@skarg
Remove non-standard token-count reset in MS/TP Answer_Data_Request st…
46e8587 
…ate.
@skarg
Fixed warning in TSM found during workflow build.
cc147fd
@skarg
Fixed dependency on Device_Segmentation_Supported().
1287b8d
@skarg
Fixed spelling errors found by codespell.
be11e02
@skarg
Fixed codespell words. Added doxygen javadoc function headers to new …
4720350 
…TSM API.
@skarg
Fixed spelling errors found by codespell.
85bedc1
@skarg
Extend the RPM property value buffer size for segmentation.
1b07f7b
nathiyaramasamy
nathiyaramasamy reviewed Apr 30, 2025
View reviewed changes
src/bacnet/basic/service/h_rp.c Outdated Show resolved Hide resolved
nathiyaramasamy
nathiyaramasamy reviewed Apr 30, 2025
View reviewed changes
src/bacnet/basic/tsm/tsm.c Outdated Show resolved Hide resolved
nathiyaramasamy
nathiyaramasamy reviewed Apr 30, 2025
View reviewed changes
src/bacnet/config.h Outdated Show resolved Hide resolved
nathiyaramasamy
nathiyaramasamy reviewed Apr 30, 2025
View reviewed changes
src/bacnet/basic/service/h_rpm.c Outdated Show resolved Hide resolved
nathiyaramasamy
nathiyaramasamy reviewed May 6, 2025
View reviewed changes
src/bacnet/bacdef.h Show resolved Hide resolved
@nathiyaramasamy nathiyaramasamy mentioned this pull request Jul 10, 2025
Closed
@skarg skarg force-pushed the bugfix/fix-pull-request-for-segmentation-additions branch 2 times, most recently from 9277186 to cc7b946 Compare July 17, 2025 15:07
nathiyaramasamy
nathiyaramasamy reviewed Jul 18, 2025
View reviewed changes
src/bacnet/basic/tsm/tsm.c Outdated Show resolved Hide resolved
nathiyaramasamy and others added 13 commits September 17, 2025 14:00
@nathiyaramasamy
Error code update in device.c
796a839
@skarg
Merge remote-tracking branch 'origin/master'
e42c267
@skarg
Merge branch 'master' into bugfix/fix-pull-request-for-segmentation-a…
65280ef 
…dditions
@skarg
Fix github workflow for lint for BACnet/SC unit test.
6fda172
@skarg
Merge remote-tracking branch 'upstream/master'
e32e56e
@skarg
Merge branch 'master' into bugfix/fix-pull-request-for-segmentation-a…
aa4c875 
…dditions
@skarg
Fixed MS/TP WAIT_FOR_REPLY master state for FrameType known to this n…
b9f85eb 
…ode.
@skarg
Fixed compiler warnings
419c942
@skarg
Enabled build option for segmented server for testing. Use SEGMENT=tr…
ad1a4b6 
…ue for Makefile build or the recipe for server-segmentation.
@skarg
Fixed MSTP for WAIT_FOR_REPLY state to allow receipt of all frames ex…
0480bec 
…cept known to not be reply frames.
@skarg
Merge remote-tracking branch 'upstream/master'
e78bdbe
@skarg
Merge remote-tracking branch 'origin/master' into bugfix/fix-pull-req…
5ed8b56 
…uest-for-segmentation-additions
@skarg
Fixed pre-commit issues with apps/server/main.c
79a04de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nathiyaramasamy nathiyaramasamy nathiyaramasamy left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skarg @nathiyaramasamy
Morty Proxy This is a proxified and sanitized view of the page, visit original site.