Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

0x587
Copy link

@0x587 0x587 commented Aug 17, 2023

I solved the problem that fastapi-crudrouter is not compatible with pydantic2.x, related issue #189, #190
The changes only involve fastapi_crudrouter/core/_utils.py

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fastapi-crudrouter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 0:10am

@cloudyyoung
Copy link

Hey I was wandering around for this issue/pr and I appreciate your work!
To add on, another line here would be schema.__fields__[pk_field].annotation for pydantic 2.x.

@0x587
Copy link
Author

0x587 commented Sep 13, 2023

Hey I was wandering around for this issue/pr and I appreciate your work! To add on, another line here would be schema.__fields__[pk_field].annotation for pydantic 2.x.

Thank you for your generous advice.
Then I got some useful information from https://docs.pydantic.dev/2.3/migration/#changes-to-pydanticbasemodel which suggested me to use model_fields instead of __fields__. I will append these changes to my PR later.

marcelomendoncasoares

This comment was marked as resolved.

@marcelomendoncasoares
Copy link

Hi, everyone! Very interested in this release, as this library will really accelerate the development of a project I have just started. Reading the history, is something still missing to approve? I'd be glad to help.

fastapi_crudrouter/core/_utils.py Outdated Show resolved Hide resolved
@lohxx
Copy link

lohxx commented Oct 24, 2023

Is there any estimate for when this PR will be merged?

@0x587
Copy link
Author

0x587 commented Oct 24, 2023

I just added the missing import, and I'm really looking forward to seeing this PR merged.
Thank help from @anthonypelletier

fastapi_crudrouter/core/_utils.py Outdated Show resolved Hide resolved
fastapi_crudrouter/core/_utils.py Outdated Show resolved Hide resolved
@0x587
Copy link
Author

0x587 commented Nov 1, 2023

Okay, I have modified the location of the import. @awtkns

@jofhanen
Copy link

This is still an issue, will this patch be updated soon?

@paulocoutinhox
Copy link

hi, can you merge?

@0x587
Copy link
Author

0x587 commented Sep 13, 2024

Waiting for @awtkns 's approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.