Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@marcomagdy
Copy link
Contributor

@marcomagdy marcomagdy commented Sep 1, 2022

That section of the FAQ was very specific to what seems like a problem with toolchain setup the author had.
Moreover, the style (and the voice) of the writing is not consistent with the rest of the README file.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

That section of the FAQ was very specific to what seems like a problem with toolchain setup the author has.
Moreover, the style (and the voice) of the writing is not consistent with the rest of the README file.
@hbobenicio
Copy link
Contributor

hbobenicio commented Sep 3, 2022

Yeah, I've later realized that the PR adding the new section on the faq was merged just before the discussion about a better way to describe the issue was started.

Anyway, please let me know if a Dockerfile demonstrating the issue could be useful (I think I can come up with an example) or if there is still interest in better describing the issue (more aligned and consistent with the rest of the README).

Sorry for the setback

@bmoffatt bmoffatt merged commit 365a4c4 into awslabs:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.