Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove duplicate content and add links to readthedocs#694

Merged
nadiaya merged 10 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom
eslesar-aws:doc-migrate-remove-duplicateeslesar-aws/sagemaker-python-sdk:doc-migrate-remove-duplicateCopy head branch name to clipboard
Mar 14, 2019
Merged

Remove duplicate content and add links to readthedocs#694
nadiaya merged 10 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom
eslesar-aws:doc-migrate-remove-duplicateeslesar-aws/sagemaker-python-sdk:doc-migrate-remove-duplicateCopy head branch name to clipboard

Conversation

@eslesar-aws
Copy link
Contributor

Issue #, if available:

Removed duplicated content from the main README.rst, /tensorflow/README.rst, and /sklearn/README.rst files and added links to the published content at ReadTheDocs.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • [x ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x ] I have updated the changelog with a description of my changes (if appropriate)
  • [x ] I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@eslesar-aws eslesar-aws requested review from laurenyu and nadiaya March 11, 2019 22:23
@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@nadiaya nadiaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main Readme.rst has invalid syntax:

Failed
The project's long_description has invalid markup which will not be rendered on PyPI. The following syntax errors were detected:
line 297: Warning: Title underline too short.

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eslesar-aws eslesar-aws requested a review from nadiaya March 13, 2019 23:31
- `inference_pipeline_sparkml_xgboost_abalone.ipynb <https://github.com/awslabs/amazon-sagemaker-examples/blob/master/advanced_functionality/inference_pipeline_sparkml_xgboost_abalone/inference_pipeline_sparkml_xgboost_abalone.ipynb>`__
- `inference_pipeline_sparkml_blazingtext_dbpedia.ipynb <https://github.com/awslabs/amazon-sagemaker-examples/blob/master/advanced_functionality/inference_pipeline_sparkml_blazingtext_dbpedia/inference_pipeline_sparkml_blazingtext_dbpedia.ipynb>`__


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing this part?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you mean the above, it's just an extra blank line.

If you mean Workflow, it hasn't been migrated yet, so it needs to stay on the GitHub page, not in overview.rst

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better to keep the Workflow section but replace the link with an absolute link to the GH readme, and then update that link once the Workflow readme has been migrated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I can migrate workflow next, so that it is there before the next release.

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nadiaya nadiaya merged commit 5f53418 into aws:master Mar 14, 2019
@eslesar-aws eslesar-aws deleted the doc-migrate-remove-duplicate branch March 14, 2019 21:23
qidewenwhen added a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Dec 13, 2022
Co-authored-by: Dewen Qi <qidewen@amazon.com>
qidewenwhen added a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Dec 14, 2022
Co-authored-by: Dewen Qi <qidewen@amazon.com>
qidewenwhen added a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Dec 14, 2022
Co-authored-by: Dewen Qi <qidewen@amazon.com>
qidewenwhen added a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Dec 14, 2022
Co-authored-by: Dewen Qi <qidewen@amazon.com>
qidewenwhen added a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Dec 14, 2022
Co-authored-by: Dewen Qi <qidewen@amazon.com>
navinsoni pushed a commit that referenced this pull request Dec 14, 2022
* feature: Add experiment plus Run class (#691)

* feature: Add Experiment helper classes (#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (#696)

* change: Update Run init and add Run load and _RunContext (#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (#754)

* fix flaky metrics test (#753)

* change: Change Run.init and Run.load to constructor and module method respectively (#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (#767)

* Change: Minimize use of lower case tc name (#769)

* change: Clean up test resources to remove model files (#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
claytonparnell pushed a commit to claytonparnell/sagemaker-python-sdk that referenced this pull request Dec 16, 2022
* feature: Add experiment plus Run class (aws#691)

* feature: Add Experiment helper classes (aws#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (aws#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (aws#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (aws#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (aws#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (aws#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (aws#696)

* change: Update Run init and add Run load and _RunContext (aws#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (aws#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (aws#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (aws#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (aws#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (aws#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (aws#754)

* fix flaky metrics test (aws#753)

* change: Change Run.init and Run.load to constructor and module method respectively (aws#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (aws#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (aws#767)

* Change: Minimize use of lower case tc name (aws#769)

* change: Clean up test resources to remove model files (aws#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (aws#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
mufaddal-rohawala pushed a commit to mufaddal-rohawala/sagemaker-python-sdk that referenced this pull request Dec 19, 2022
* feature: Add experiment plus Run class (aws#691)

* feature: Add Experiment helper classes (aws#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (aws#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (aws#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (aws#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (aws#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (aws#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (aws#696)

* change: Update Run init and add Run load and _RunContext (aws#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (aws#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (aws#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (aws#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (aws#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (aws#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (aws#754)

* fix flaky metrics test (aws#753)

* change: Change Run.init and Run.load to constructor and module method respectively (aws#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (aws#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (aws#767)

* Change: Minimize use of lower case tc name (aws#769)

* change: Clean up test resources to remove model files (aws#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (aws#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
mufaddal-rohawala pushed a commit that referenced this pull request Dec 20, 2022
* feature: Add experiment plus Run class (#691)

* feature: Add Experiment helper classes (#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (#696)

* change: Update Run init and add Run load and _RunContext (#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (#754)

* fix flaky metrics test (#753)

* change: Change Run.init and Run.load to constructor and module method respectively (#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (#767)

* Change: Minimize use of lower case tc name (#769)

* change: Clean up test resources to remove model files (#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
* feature: Add experiment plus Run class (aws#691)

* feature: Add Experiment helper classes (aws#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (aws#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (aws#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (aws#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (aws#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (aws#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (aws#696)

* change: Update Run init and add Run load and _RunContext (aws#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (aws#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (aws#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (aws#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (aws#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (aws#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (aws#754)

* fix flaky metrics test (aws#753)

* change: Change Run.init and Run.load to constructor and module method respectively (aws#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (aws#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (aws#767)

* Change: Minimize use of lower case tc name (aws#769)

* change: Clean up test resources to remove model files (aws#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (aws#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
* feature: Add experiment plus Run class (aws#691)

* feature: Add Experiment helper classes (aws#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (aws#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (aws#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (aws#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (aws#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (aws#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (aws#696)

* change: Update Run init and add Run load and _RunContext (aws#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (aws#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (aws#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (aws#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (aws#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (aws#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (aws#754)

* fix flaky metrics test (aws#753)

* change: Change Run.init and Run.load to constructor and module method respectively (aws#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (aws#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (aws#767)

* Change: Minimize use of lower case tc name (aws#769)

* change: Clean up test resources to remove model files (aws#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (aws#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
* feature: Add experiment plus Run class (aws#691)

* feature: Add Experiment helper classes (aws#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (aws#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (aws#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (aws#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (aws#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (aws#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (aws#696)

* change: Update Run init and add Run load and _RunContext (aws#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (aws#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (aws#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (aws#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (aws#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (aws#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (aws#754)

* fix flaky metrics test (aws#753)

* change: Change Run.init and Run.load to constructor and module method respectively (aws#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (aws#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (aws#767)

* Change: Minimize use of lower case tc name (aws#769)

* change: Clean up test resources to remove model files (aws#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (aws#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.