fix README for PyPI#643
Merged
nadiaya merged 1 commit intoaws:masteraws/sagemaker-python-sdk:masterfrom Feb 14, 2019
ChoiByungWook:fix_pypi_docsCopy head branch name to clipboard
Merged
fix README for PyPI#643nadiaya merged 1 commit intoaws:masteraws/sagemaker-python-sdk:masterfrom ChoiByungWook:fix_pypi_docsCopy head branch name to clipboard
nadiaya merged 1 commit intoaws:masteraws/sagemaker-python-sdk:masterfrom
ChoiByungWook:fix_pypi_docsCopy head branch name to clipboard
Conversation
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
+ Coverage 92.75% 92.77% +0.01%
==========================================
Files 71 71
Lines 5465 5465
==========================================
+ Hits 5069 5070 +1
+ Misses 396 395 -1
Continue to review full report at Codecov.
|
nadiaya
approved these changes
Feb 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The README doc is broken in PyPI: https://pypi.org/project/sagemaker/1.18.3/
The code snippet below was missing a newline.
Twine provides the ability to check if your readme will render properly on PyPI.
https://packaging.python.org/guides/making-a-pypi-friendly-readme/#validating-restructuredtext-markup
aws/sagemaker-tensorflow-extensions#32
Description of changes:
Added newline in code snippet portion in README.
Bumped to 1.18.3.post1
Going to add the step in our CI.
=== TEST ===
twine check dist/*
/anaconda3/lib/python3.6/site-packages/readme_renderer/markdown.py:38: UserWarning: Markdown renderers are not available. Install 'readme_render[md]' to enable Markdown rendering.
warnings.warn(_EXTRA_WARNING)
Checking distribution dist/sagemaker-1.18.3.post1.tar.gz: Passed
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.