sync (#63)#64
Closed
ragavvenkatesan wants to merge 1 commit intomasteraws/sagemaker-python-sdk:masterfrom
Closed
Conversation
* add sagemaker cli (#32) * add sagemaker cli * remove unnecessary close * address PR comments * tidy up imports * fix imports, flake8 errors * improve help message for bucket-name * remove default role name * fix log-level and py3 tests, add copyright * update cli example scripts * Add documentation about BYO Models (#47) * Add test for BYO estimator using Factorization Machines algorithm as an example. (#50) * Support multi-part uploads (#45) * Update TensorFlow examples following API change (#44) * Add data_type to hyperparameters (#54) When we describe a training job the data type of the hyper parameters is lost because we use a dict[str, str]. This adds a new field to Hyperparameter so that we can convert the datatypes at runtime. instead of validating with isinstance(), we cast the hp value to the type it is meant to be. This enforces a "strongly typed" value. When we deserialize from the API string responses it becomes easier to deal with too.
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add sagemaker cli (add sagemaker cli #32)
add sagemaker cli
remove unnecessary close
address PR comments
tidy up imports
fix imports, flake8 errors
improve help message for bucket-name
remove default role name
fix log-level and py3 tests, add copyright
update cli example scripts
Add documentation about BYO Models (Add documentation about BYO Models #47)
Add test for BYO estimator using Factorization Machines algorithm as an example. (Add test for BYO estimator #50)
Support multi-part uploads (Support multi-part uploads #45)
Update TensorFlow examples following API change (Update TensorFlow examples following API change #44)
Add data_type to hyperparameters (Add data_type to hyperparameters #54)
When we describe a training job the data type of the hyper parameters is
lost because we use a dict[str, str]. This adds a new field to
Hyperparameter so that we can convert the datatypes at runtime.
instead of validating with isinstance(), we cast the hp value to the type it
is meant to be. This enforces a "strongly typed" value. When we
deserialize from the API string responses it becomes easier to deal with
too.