fix: Remove hardcoded secret key from Triton ONNX export path#5653
Open
pravali96 wants to merge 1 commit intoaws:masteraws/sagemaker-python-sdk:masterfrom
pravali96:fix/remove-hardcoded-triton-onnx-secret-keypravali96/sagemaker-python-sdk:fix/remove-hardcoded-triton-onnx-secret-keyCopy head branch name to clipboard
Open
fix: Remove hardcoded secret key from Triton ONNX export path#5653pravali96 wants to merge 1 commit intoaws:masteraws/sagemaker-python-sdk:masterfrom pravali96:fix/remove-hardcoded-triton-onnx-secret-keypravali96/sagemaker-python-sdk:fix/remove-hardcoded-triton-onnx-secret-keyCopy head branch name to clipboard
pravali96 wants to merge 1 commit intoaws:masteraws/sagemaker-python-sdk:masterfrom
pravali96:fix/remove-hardcoded-triton-onnx-secret-keypravali96/sagemaker-python-sdk:fix/remove-hardcoded-triton-onnx-secret-keyCopy head branch name to clipboard
Conversation
The ONNX export path in _prepare_for_triton() set self.secret_key to a hardcoded value 'dummy secret key for onnx backend'. This key was then passed as SAGEMAKER_SERVE_SECRET_KEY into container environment variables and exposed in plaintext via DescribeModel/DescribeEndpointConfig APIs. The ONNX path does not use pickle serialization — models are exported to .onnx format and loaded natively by Triton's ONNX Runtime backend. There is no serve.pkl, no metadata.json, and no integrity check to perform. The secret key was dead code that also constituted a hardcoded credential (CWE-798). With this change, self.secret_key remains empty string (set by _build_for_triton), and the existing cleanup in _build_for_transformers removes empty SAGEMAKER_SERVE_SECRET_KEY from env_vars before CreateModel. Addresses: P400136088 (Bug 2 - Hardcoded secret key)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ONNX export path in _prepare_for_triton() set self.secret_key to a hardcoded value 'dummy secret key for onnx backend'. This key was then passed as SAGEMAKER_SERVE_SECRET_KEY into container environment variables and exposed in plaintext via DescribeModel/DescribeEndpointConfig APIs.
The ONNX path does not use pickle serialization — models are exported to .onnx format and loaded natively by Triton's ONNX Runtime backend. There is no serve.pkl, no metadata.json, and no integrity check to perform. The secret key was dead code that also constituted a hardcoded credential (CWE-798).
With this change, self.secret_key remains empty string (set by _build_for_triton), and the existing cleanup in _build_for_transformers removes empty SAGEMAKER_SERVE_SECRET_KEY from env_vars before CreateModel.
Addresses: P400136088 (Bug 2 - Hardcoded secret key)
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.