fix: use is None instead of == None (PEP 8 E711)#5651
Open
harshadkhetpal wants to merge 2 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom
harshadkhetpal:fix/pep8-is-none-codegenharshadkhetpal/sagemaker-python-sdk:fix/pep8-is-none-codegenCopy head branch name to clipboard
Open
fix: use is None instead of == None (PEP 8 E711)#5651harshadkhetpal wants to merge 2 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom harshadkhetpal:fix/pep8-is-none-codegenharshadkhetpal/sagemaker-python-sdk:fix/pep8-is-none-codegenCopy head branch name to clipboard
is None instead of == None (PEP 8 E711)#5651harshadkhetpal wants to merge 2 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom
harshadkhetpal:fix/pep8-is-none-codegenharshadkhetpal/sagemaker-python-sdk:fix/pep8-is-none-codegenCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
== Nonewithis Nonein two files undersagemaker-core/src/sagemaker/core/tools/to comply with PEP 8 E711.Using
is/is notfor None comparisons is the recommended Python idiom sinceNoneis a singleton.Changes:
resources_codegen.pyline 646:if documentation == None:->if documentation is None:templates.pyline 647:elif value == None or not value:->elif value is None or not value:Testing
No behavior change —
is Noneis semantically equivalent for None comparisons and is the PEP 8 recommended style.