fix: Add HMAC integrity verification for Triton inference handler#5646
Open
pravali96 wants to merge 2 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom
pravali96:fix/triton-hmac-security-v3pravali96/sagemaker-python-sdk:fix/triton-hmac-security-v3Copy head branch name to clipboard
Open
fix: Add HMAC integrity verification for Triton inference handler#5646pravali96 wants to merge 2 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom pravali96:fix/triton-hmac-security-v3pravali96/sagemaker-python-sdk:fix/triton-hmac-security-v3Copy head branch name to clipboard
pravali96 wants to merge 2 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom
pravali96:fix/triton-hmac-security-v3pravali96/sagemaker-python-sdk:fix/triton-hmac-security-v3Copy head branch name to clipboard
Conversation
f832dd2 to
90d93dd
Compare
9ed3c6d to
187eecb
Compare
115b927 to
9ae59b2
Compare
- Add HMAC integrity check before pickle deserialization in TritonPythonModel.initialize() - Replace hardcoded secret key with generate_secret_key() in _prepare_for_triton() ONNX path - Add _hmac_signing() after ONNX export for both PyTorch and TensorFlow frameworks - Add secret key validation in _start_triton_server() to reject None/empty keys Fixes RCE vulnerabilities in Triton handler by aligning with HMAC verification patterns used by TorchServe, MMS, TF Serving, and SMD handlers.
9ae59b2 to
7101c0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes RCE vulnerabilities in Triton handler by aligning with HMAC verification patterns used by TorchServe, MMS, TF Serving, and SMD handlers.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.