fix: HyperparameterTuner to pass enable_managed_spot_training flag to training jobs#5597
Open
toddstep wants to merge 3 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom
toddstep:fix_hypertuner_managed_spot_350toddstep/sagemaker-python-sdk:fix_hypertuner_managed_spot_350Copy head branch name to clipboard
Open
fix: HyperparameterTuner to pass enable_managed_spot_training flag to training jobs#5597toddstep wants to merge 3 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom toddstep:fix_hypertuner_managed_spot_350toddstep/sagemaker-python-sdk:fix_hypertuner_managed_spot_350Copy head branch name to clipboard
toddstep wants to merge 3 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom
toddstep:fix_hypertuner_managed_spot_350toddstep/sagemaker-python-sdk:fix_hypertuner_managed_spot_350Copy head branch name to clipboard
Conversation
…ot parameters HyperparameterTuner._build_training_job_definition() was not copying parameters needed for managed spot training: - enable_managed_spot_training - max_wait_time_in_seconds This caused training jobs to launch with on-demend instances. - Include the additional parameters in the job definition - Add a unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HyperparameterTuner._build_training_job_definition()is not copying parameters needed for managed spot training:enable_managed_spot_trainingmax_wait_time_in_secondsThis causes training jobs to launch with on-demand instances.
*Issue #5584
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.