fix rst warnings#381
Merged
jesterhazy merged 6 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom Sep 5, 2018
jesterhazy:masterCopy head branch name to clipboard
Merged
fix rst warnings#381jesterhazy merged 6 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom jesterhazy:masterCopy head branch name to clipboard
jesterhazy merged 6 commits intoaws:masteraws/sagemaker-python-sdk:masterfrom
jesterhazy:masterCopy head branch name to clipboard
Conversation
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
======================================
Coverage 92.9% 92.9%
======================================
Files 51 51
Lines 3568 3568
======================================
Hits 3315 3315
Misses 253 253Continue to review full report at Codecov.
|
laurenyu
previously approved these changes
Sep 5, 2018
nadiaya
previously approved these changes
Sep 5, 2018
README.rst
Outdated
| 3. The AWS account has an IAM role named :code:`SageMakerRole` | ||
| 4. The libraries listed in the ``extra_require`` object in in ``setup.py`` for ``test`` are installed. You can do this by running the following command: | ||
| :code:`pip install --upgrade .[test]` | ||
| 4. The libraries listed in the ``extras_require`` object in in ``setup.py`` for ``test`` are installed. |
added 2 commits
September 5, 2018 09:21
Contributor
Author
|
@nadiaya addressed PR comments |
laurenyu
previously approved these changes
Sep 5, 2018
laurenyu
approved these changes
Sep 5, 2018
nadiaya
approved these changes
Sep 5, 2018
pdasamzn
pushed a commit
to pdasamzn/sagemaker-python-sdk
that referenced
this pull request
Nov 1, 2018
* fix rst warnings * fix typo * fix image link * update version to 1.9.3.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
fix RST warnings in the readme file
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.