change: use recommended inference image uri from Neo API by HappyAmazonian · Pull Request #2923 · aws/sagemaker-python-sdk

HappyAmazonian · Feb 9, 2022

Issue #, if available:

Description of changes:

use recommended inference image URI from Neo DescribeCompilationJob API response
related unit tests
Creating a new one since the last PR gets messier overtime.

Testing done:
unit tests passed

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · Feb 9, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 64d49cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

HappyAmazonian · Feb 9, 2022

According to log,

black-check run-test: commands[0] | black -l 100 --check ./
would reformat doc/conf.py
would reformat tests/integ/sagemaker/lineage/helpers.py
would reformat tests/integ/test_workflow_retry.py
would reformat src/sagemaker/utils.py
would reformat tests/unit/sagemaker/feature_store/test_feature_store.py
would reformat src/sagemaker/analytics.py
would reformat tests/integ/test_workflow.py

Oh no! 💥 💔 💥
7 files would be reformatted, 514 files would be left unchanged.
ERROR: InvocationError for command /local/home/sheteng/sagemaker-python-sdk/.tox/black-check/bin/black -l 100 --check ./ (exited with code 1)
___________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________
ERROR:   black-check: commands failed

Unit tests failed, due to something unrelated to the change. It failed on master too.

shreyapandit · Feb 9, 2022

src/sagemaker/model.py

-                    framework,
-                    framework_version,
-                )
+                self.image_uri = job_status.get("InferenceImage", None)


Is this param expected to be there always? What if this is None? Is the removed method needed?

Neo service puts InferenceImage in the response according to the API response. In the case that the user uses ml instance, the InferenceImage will not be None from our service.
We are making this change so the user can get the latest inference url recommendation.

Is the removed method needed?
Thanks for pointing out. Will delete it

sagemaker-bot · Feb 9, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 64d49cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 9, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 64d49cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 9, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4582c5f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 9, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 64d49cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 9, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4582c5f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 9, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4582c5f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · Feb 10, 2022

Codecov Report

Merging #2923 (7777e01) into dev (3c5ea3a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #2923   +/-   ##
=======================================
  Coverage   89.49%   89.49%           
=======================================
  Files         195      195           
  Lines       16567    16558    -9     
=======================================
- Hits        14826    14818    -8     
+ Misses       1741     1740    -1

Impacted Files	Coverage Δ
src/sagemaker/model.py	`91.48% <100.00%> (+0.07%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c5ea3a...7777e01. Read the comment docs.

sagemaker-bot · Feb 10, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6d991f2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 10, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6d991f2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 10, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6d991f2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 10, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6d991f2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni · Feb 9, 2022

doc/frameworks/pytorch/using_pytorch.rst


 For more information on the default inference handler functions, please refer to:
-`SageMaker PyTorch Default Inference Handler <https://github.com/aws/sagemaker-pytorch-serving-container/blob/master/src/sagemaker_pytorch_serving_container/default_inference_handler.py>`_.
+`SageMaker PyTorch Default Inference Handler <https://github.com/aws/sagemaker-pytorch-inference-toolkit/blob/master/src/sagemaker_pytorch_serving_container/default_pytorch_inference_handler.py>`_.


have we changed repo here

sagemaker-bot · Feb 16, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7777e01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 16, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7777e01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 16, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7777e01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 16, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7777e01
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 16, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7777e01
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · Feb 16, 2022

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7777e01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

HappyAmazonian mentioned this pull request Feb 9, 2022

change: use recommended inference image URI from Neo API #2806

Closed

9 tasks

shreyapandit reviewed Feb 9, 2022

View reviewed changes

HappyAmazonian force-pushed the inf-url branch from 64d49cb to 4582c5f Compare February 9, 2022 20:53

navinsoni self-requested a review February 9, 2022 21:36

change: use recommended inference image uri from Neo API

6d991f2

HappyAmazonian force-pushed the inf-url branch from 4582c5f to 6d991f2 Compare February 10, 2022 01:58

shreyapandit approved these changes Feb 15, 2022

View reviewed changes

Merge branch 'dev' into inf-url

7777e01

navinsoni approved these changes Feb 16, 2022

View reviewed changes

navinsoni merged commit a765512 into aws:dev Feb 16, 2022

navinsoni pushed a commit that referenced this pull request Feb 16, 2022

change: use recommended inference image uri from Neo API (#2923)

7af5de6

navinsoni pushed a commit that referenced this pull request Feb 17, 2022

change: use recommended inference image uri from Neo API (#2923)

ef6d2e5

Search code, repositories, users, issues, pull requests...

Conversation

HappyAmazonian commented Feb 9, 2022

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

Uh oh!

HappyAmazonian commented Feb 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shreyapandit Feb 9, 2022

Choose a reason for hiding this comment

Uh oh!

HappyAmazonian Feb 9, 2022

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Feb 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Feb 10, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 10, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 10, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 10, 2022

AWS CodeBuild CI Report

Uh oh!

navinsoni Feb 9, 2022

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

HappyAmazonian commented Feb 9, 2022 •

edited

Loading

codecov-commenter commented Feb 10, 2022 •

edited

Loading