fix endpoint bug#2772
Merged
BasilBeirouti merged 1 commit intodevaws/sagemaker-python-sdk:devfrom Dec 6, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2772 +/- ##
==========================================
- Coverage 88.71% 88.70% -0.01%
==========================================
Files 167 167
Lines 14766 14765 -1
==========================================
- Hits 13099 13098 -1
Misses 1667 1667
Continue to review full report at Codecov.
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
navinsoni
reviewed
Nov 25, 2021
Comment on lines
+3565
to
+3569
| self.sagemaker_client.create_endpoint_config(**config_options) | ||
|
|
Contributor
There was a problem hiding this comment.
How are you checking if the endpoint exists or not
How are you notifying customers if endpoint config already exists
Contributor
There was a problem hiding this comment.
your coverage is reducing. Please add unit tests
Contributor
Author
There was a problem hiding this comment.
The endpoint check happens in the create_endpoint_config call in the boto3 layer. It is raised in that method call on line 3565 and propagates up the call stack to the endpoint_from_production_variants() method
031d43f to
2fdad08
Compare
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
2991272 to
c35da48
Compare
mufaddal-rohawala
previously approved these changes
Dec 6, 2021
c35da48 to
46baa68
Compare
ahsan-z-khan
approved these changes
Dec 6, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mufaddal-rohawala
approved these changes
Dec 6, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
BasilBeirouti
added a commit
that referenced
this pull request
Dec 8, 2021
Co-authored-by: Basil Beirouti <beirb@amazon.com>
shreyapandit
pushed a commit
that referenced
this pull request
Jan 11, 2022
Co-authored-by: Basil Beirouti <beirb@amazon.com>
EthanShouhanCheng
pushed a commit
to SissiChenxy/sagemaker-python-sdk
that referenced
this pull request
Jan 11, 2022
Co-authored-by: Basil Beirouti <beirb@amazon.com>
shreyapandit
added a commit
that referenced
this pull request
Feb 3, 2022
* feature: allow conditional parellel builds (#2727) * fix endpoint bug (#2772) Co-authored-by: Basil Beirouti <beirb@amazon.com> * fix: local mode - support relative file structure (#2768) * prepare release v2.72.0 * update development version to v2.72.1.dev0 * fix: Set ProcessingStep upload locations deterministically to avoid c… (#2790) * fix: Prevent repack_model script from referencing nonexistent directories (#2755) Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com> * fix: S3Input - add support for instance attributes (#2754) * fix: typos and broken link (#2765) Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com> * prepare release v2.72.1 * update development version to v2.72.2.dev0 * fix: Model Registration with BYO scripts (#2797) Co-authored-by: Basil Beirouti <beirb@amazon.com> Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: Basil Beirouti <BasilBeirouti@gmail.com> Co-authored-by: Payton Staub <staubhpa@gmail.com> Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com> * fix: Add ContentType in test_auto_ml_describe * fix: Re-deploy static integ test endpoint if it is not found * documentation :SageMaker model parallel library 1.6.0 API doc (#2814) * update smdmp change log, archive api doc for 1.4.0 and 1.5.0 * add no-index flags * finish api doc archive * fix: Set ProcessingStep upload locations deterministically to avoid c… (#2790) * fix: Prevent repack_model script from referencing nonexistent directories (#2755) Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com> * fix: S3Input - add support for instance attributes (#2754) * fix: typos and broken link (#2765) Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com> * add all api docs * add appendix, fix links * structural changes, fix links * incorporate feedback * prepare release v2.72.1 * update development version to v2.72.2.dev0 Co-authored-by: Payton Staub <staubhpa@gmail.com> Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: Mohamed Ali Jamaoui <m.ali.jamaoui@gmail.com> Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com> Co-authored-by: ci <ci> Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com> * fix: fix kmeans test deletion sequence, increment lineage statics (#2815) * fix: Increment static lineage pipeline (#2817) * fix: Update CHANGELOG.md (#2832) * prepare release v2.72.2 * update development version to v2.72.3.dev0 * change: update master from dev (#2836) Co-authored-by: Basil Beirouti <beirb@amazon.com> Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: Basil Beirouti <BasilBeirouti@gmail.com> Co-authored-by: Payton Staub <staubhpa@gmail.com> Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com> Co-authored-by: Mohamed Ali Jamaoui <m.ali.jamaoui@gmail.com> Co-authored-by: ci <ci> Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com> Co-authored-by: sreedes <70613743+sreedes@users.noreply.github.com> Co-authored-by: Navin Soni <navinns@amazon.com> Co-authored-by: Miyoung <myoung8739@gmail.com> Co-authored-by: Ameen Khan <ameenmk@amazon.com> Co-authored-by: Zhankui Lu <zhankuil@amazon.com> Co-authored-by: Xiaoguang Chen <68292680+xgchena@users.noreply.github.com> Co-authored-by: Jonathan Guinegagne <12092593+JGuinegagne@users.noreply.github.com> Co-authored-by: Zhankui Lu <zhankuilv@gmail.com> Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com> Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com> * prepare release v2.72.3 * update development version to v2.72.4.dev0 * fix: fixes unnecessary session call while generating pipeline definition for lambda step (#2824) * feature: Add models_v2 under lineage context (#2800) * feature: enable python 3.9 (#2802) Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com> * change: Update CHANGELOG.md (#2842) * fix: update pricing link (#2805) Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com> Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com> Co-authored-by: Basil Beirouti <beirb@amazon.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: Basil Beirouti <BasilBeirouti@gmail.com> Co-authored-by: Payton Staub <staubhpa@gmail.com> Co-authored-by: Mohamed Ali Jamaoui <m.ali.jamaoui@gmail.com> Co-authored-by: ci <ci> Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com> Co-authored-by: sreedes <70613743+sreedes@users.noreply.github.com> Co-authored-by: Navin Soni <navinns@amazon.com> Co-authored-by: Miyoung <myoung8739@gmail.com> Co-authored-by: Ameen Khan <ameenmk@amazon.com> Co-authored-by: Zhankui Lu <zhankuil@amazon.com> Co-authored-by: Navin Soni <navinsoni89@gmail.com> Co-authored-by: Xiaoguang Chen <68292680+xgchena@users.noreply.github.com> Co-authored-by: Jonathan Guinegagne <12092593+JGuinegagne@users.noreply.github.com> Co-authored-by: Zhankui Lu <zhankuilv@gmail.com> Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com> Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com> * doc: Document the available ExecutionVariables (#2807) * fix: Remove duplicate vertex/edge in query lineage (#2784) * feature: Support model pipelines in CreateModelStep (#2845) Co-authored-by: Payton Staub <pstaub@amazon.com> * feature: support JsonGet/Join parameterization in tuning step Hyperparameters (#2833) * doc: Enhance smddp 1.2.2 doc (#2852) * feature: support checkpoint to be passed from estimator (#2849) Co-authored-by: marckarp <karpmar@8c859028ba7e.ant.amazon.com> * fix: allow kms_key to be passed for processing step (#2779) * feature: Adds support for Serverless inference (#2831) * feature: Add support for SageMaker lineage queries in action (#2853) * feature: Adds Lineage queries in artifact, context and trial components (#2838) * feature: Add EMRStep support in Sagemaker pipeline (#2848) Co-authored-by: chenxy <chenxy@amazon.com> * prepare release v2.73.0 * update development version to v2.73.1.dev0 * feature: Add support for SageMaker lineage queries context (#2830) * fix: support specifying a facet by its column index Currently the Clarify BiasConfig only accepts facet name. Actually Clarify analysis configuration supports both name and index. This commit adds the same support to BiasConfig. * doc: more documentation for serverless inference (#2859) * prepare release v2.74.0 * update development version to v2.74.1.dev0 * Add deprecation warning in Clarify DataConfig (#2847) * feature: Update instance types for integ test (#2881) * feature: Adds support for async inference (#2846) * fix: update to incorporate black v22, pin tox versions (#2889) Co-authored-by: Mufaddal Rohawala <muffi179@gmail.com> * make black happy Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: Basil Beirouti <BasilBeirouti@gmail.com> Co-authored-by: Basil Beirouti <beirb@amazon.com> Co-authored-by: ci <ci> Co-authored-by: Payton Staub <staubhpa@gmail.com> Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com> Co-authored-by: Mohamed Ali Jamaoui <m.ali.jamaoui@gmail.com> Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com> Co-authored-by: sreedes <70613743+sreedes@users.noreply.github.com> Co-authored-by: Navin Soni <navinns@amazon.com> Co-authored-by: Miyoung <myoung8739@gmail.com> Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com> Co-authored-by: Ameen Khan <ameenmk@amazon.com> Co-authored-by: Zhankui Lu <zhankuil@amazon.com> Co-authored-by: Xiaoguang Chen <68292680+xgchena@users.noreply.github.com> Co-authored-by: Jonathan Guinegagne <12092593+JGuinegagne@users.noreply.github.com> Co-authored-by: Zhankui Lu <zhankuilv@gmail.com> Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com> Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com> Co-authored-by: Xinghan Chen <47259301+xchen909@users.noreply.github.com> Co-authored-by: Navin Soni <navinsoni89@gmail.com> Co-authored-by: Tulio Casagrande <tuliocasagrande@gmail.com> Co-authored-by: jerrypeng7773 <50377760+jerrypeng7773@users.noreply.github.com> Co-authored-by: marckarp <mkarpmar@gmail.com> Co-authored-by: marckarp <karpmar@8c859028ba7e.ant.amazon.com> Co-authored-by: jayatalr <69013381+jayatalr@users.noreply.github.com> Co-authored-by: bhaoz <96764005+bhaoz@users.noreply.github.com> Co-authored-by: Ethan Cheng <shouhc@amazon.com> Co-authored-by: chenxy <chenxy@amazon.com> Co-authored-by: Xiaoguang Chen <xgchen@amazon.com> Co-authored-by: keerthanvasist <kvasist@amazon.com> Co-authored-by: Mufaddal Rohawala <muffi179@gmail.com> Co-authored-by: Shreya Pandit <pandishr@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
When an existing endpoint config exists with an identical name, throw an error instead of reusing it. The reason is that when the model.deploy() method is called, the model on which the deploy() method is called may not be the same model which is configured in the existing endpoint config. It is safer to throw an error, the same way that an error is thrown when an endpoint with the same name exists.
See the ticket for more information:
https://t.corp.amazon.com/P46903451
Testing done: unit tests all pass
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.