Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Default to standard retry #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: version-3
Choose a base branch
Loading
from
Open

Default to standard retry #3236

wants to merge 6 commits into from

Conversation

mullermp
Copy link
Contributor

Sets the default retry strategy to standard.

This is a mild breaking change, rendering some config values useless (since standard doesn't have too many configurable options).

DynamoDB extended retries will include a new default of 10 retries but no configurable jitter/backoff policy unless configured back to legacy.

Other changes to the retry plugin are rubocop related.

Copy link

Detected 1 possible performance regressions:

  • aws-sdk-dynamodb.put_item_small_ms - z-score regression: 0.7 -> 1.05. Z-score: 31.16

Copy link
Contributor

@jterapin jterapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

gems/aws-sdk-core/lib/aws-sdk-core/plugins/retry_errors.rb Outdated Show resolved Hide resolved
Co-authored-by: Juli Tera <57973151+jterapin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.