Migration from json.org json code to Android re-implementation#271
Closed
eethomas wants to merge 2 commits intoaws:masteraws/aws-sdk-java:masterfrom
Closed
Migration from json.org json code to Android re-implementation#271eethomas wants to merge 2 commits intoaws:masteraws/aws-sdk-java:masterfrom
eethomas wants to merge 2 commits intoaws:masteraws/aws-sdk-java:masterfrom
Conversation
added 2 commits
September 12, 2014 11:55
Contributor
|
Hey Evan, thanks for the contribution. We've actually been working on completely removing the json.org code from the SDK. The license is kind of strange, like you mentioned, plus we already have a dependency on Jackson, so we'd like to simplify. Currently there are two places left in the SDK codebase where the json.org code is used: generated request marshaller types, and error response unmarshalling. I'll sync up with the team, but my gut feeling is we'd probably prefer to spend the time completely removing all use of the json.org interface, instead of switching over to this better Android implementation of the API. It'll probably be a little more effort to get rid of the json.org API use, but might make more sense in the long run. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android re-implementation of the json.org code was a clean room reimplementation of the APIs in the json.org code. Json.org's licence contains the phrase "The Software shall be used for Good, not Evil." which some have interpreted to be a "field-of-use restriction" incompatible with some open source licenses (including the GPL). This patch removes all code from the json.org codebase and replaces it with the Android-reimplementation (https://apps.fedoraproject.org/packages/android-json-org-java), with a few minor changes to allow compilation with the AWS SDK.
Changes from Android: