Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Only add URL query if it's not empty #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
calavera merged 1 commit into from
Oct 18, 2024
Merged

Only add URL query if it's not empty #933

calavera merged 1 commit into from
Oct 18, 2024

Conversation

@RaeesBhatti
Copy link
Contributor

@RaeesBhatti RaeesBhatti commented Oct 17, 2024

馃摤 Issue #, if available:

鉁嶏笍 Description of changes:
In the current state, the runtime adds a ? to every request URL even if the query was not set. This change fixes that behavior for AWS API Gateway V2 requests.

馃攺 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

calavera
calavera approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@calavera calavera merged commit 19c190d into aws:main Oct 18, 2024
@RaeesBhatti RaeesBhatti deleted the patch-1 branch October 18, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@calavera calavera calavera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RaeesBhatti @calavera
Morty Proxy This is a proxified and sanitized view of the page, visit original site.