Expand on the CloudTrail event #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial contribution of the CloudTrail event was not complete, but rather constructed from a handful of event examples. The structure is documented at https://docs.aws.amazon.com/awscloudtrail/latest/userguide/cloudtrail-event-reference-user-identity.html which covers a number of optional fields and fields that are not already covered.
calavera
suggested changes
Jul 8, 2024
Contributor
calavera
left a comment
There was a problem hiding this comment.
It doesn't look like we have any tests for these events. Can you add some like we have in other event modules?
calavera
approved these changes
Jul 10, 2024
Contributor
calavera
left a comment
There was a problem hiding this comment.
Thanks a lot for making these improvements!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摤 Issue #, if available:
N/A
鉁嶏笍 Description of changes:
The initial contribution of the CloudTrail event was not complete, but rather constructed from a handful of event examples. The structure is documented at:
which indicates a number of optional fields and more fields that weren't already covered.
馃攺 By submitting this pull request
cargo +nightly fmt.cargo clippy --fix.