Enable automated releases #1083
Conversation
| release-plz-release: | ||
| name: Release-plz release | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.repository_owner == 'aws' }} |
There was a problem hiding this comment.
What's the purpose of this check? Making sure that the push is not coming from a forked repo?
There was a problem hiding this comment.
Well, it's so that it doesn't run on forks.
But even if somebody removed it, it still won't pus to crates io.
There was a problem hiding this comment.
Yeah just a convenience to avoid ci failures on forks. It would be great to add similar for the integration test workflow.
jlizen
left a comment
There was a problem hiding this comment.
Changes look reasonable to me, though I believe there is some internal discussion about some extra review processes.
Only other feedback is, it might be nice to have a small passage in CONTRIBUTING.md explaining how to kick off a release.
| release-plz-release: | ||
| name: Release-plz release | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.repository_owner == 'aws' }} |
There was a problem hiding this comment.
Yeah just a convenience to avoid ci failures on forks. It would be great to add similar for the integration test workflow.
| @@ -0,0 +1,10 @@ | ||
| [workspace] | ||
| semver_check = true |
There was a problem hiding this comment.
This is somewhat redundant with our cargo semver check workflow right? I don't mind keeping it though for defense in depth.
馃摤 Issue #, if available:
鉁嶏笍 Description of changes:
Adds support for automated releases
馃攺 By submitting this pull request
cargo +nightly fmt.cargo clippy --fix.