[alc] fix nullpointer exception when logging null (#38)#439
Merged
smirnoal merged 1 commit intomainaws/aws-lambda-java-libs:mainfrom Sep 4, 2023
torokd-fix-nullpointer-exceptionaws/aws-lambda-java-libs:torokd-fix-nullpointer-exceptionCopy head branch name to clipboard
Merged
[alc] fix nullpointer exception when logging null (#38)#439smirnoal merged 1 commit intomainaws/aws-lambda-java-libs:mainfrom torokd-fix-nullpointer-exceptionaws/aws-lambda-java-libs:torokd-fix-nullpointer-exceptionCopy head branch name to clipboard
smirnoal merged 1 commit intomainaws/aws-lambda-java-libs:mainfrom
torokd-fix-nullpointer-exceptionaws/aws-lambda-java-libs:torokd-fix-nullpointer-exceptionCopy head branch name to clipboard
Conversation
* [alc] fix nullpointer exception when logging null --------- Co-authored-by: Daniel Torok <torokd@amazon.com>
anton-stepanof
approved these changes
Sep 4, 2023
smirnoal
approved these changes
Sep 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Integration tests highlighted a problem, when logging a
nullobject the runtime crashed withNullPointerException.With this fix either the log formatter will handle the
nullvalue, or theContextLoggerwhen no formatting is involved,AbstractLoggerwill just pass it.Target (OCI, Managed Runtime, both): both
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.