Missing version field#258
Merged
carlzogh merged 7 commits intoaws:masteraws/aws-lambda-java-libs:masterfrom Aug 26, 2021
msailes:missing-version-fieldCopy head branch name to clipboard
Merged
Missing version field#258carlzogh merged 7 commits intoaws:masteraws/aws-lambda-java-libs:masterfrom msailes:missing-version-fieldCopy head branch name to clipboard
carlzogh merged 7 commits intoaws:masteraws/aws-lambda-java-libs:masterfrom
msailes:missing-version-fieldCopy head branch name to clipboard
Conversation
Contributor
Author
|
I've tested all these variations on AWS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#207
Description of changes:
This is a little complex due to the various different modes of operation around REST and HTTP APIs, with the old (v1) and new (v2) message formats.
APIGatewayProxyRequestEventa version won't be set. This doesn't cause a problem, butgetVersion()does return a null.APIGatewayProxyRequestEventwill have "1.0" set for the version.APIGatewayProxyRequestEventwill have "2.0" set for the version.APIGatewayV2HTTPEventto take advantage of the changes.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.