fix: mysql deadlock on is_closed during wrapper destructor #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faviansamatha
commented
Dec 20, 2025
| return prop_copy | ||
|
|
||
| def is_closed(self, conn: Connection) -> bool: | ||
| def is_closed(self, conn: Connection, is_releasing_resources: bool = False) -> bool: |
Contributor
Author
There was a problem hiding this comment.
Was discussed offline, I'm not a big fan of this and changing the driver dialects. Ideally, we should be maintaining the lifecycle of ThreadPoolExecutors. This way, it won't be shut down when a destructor is called on the wrapper while the executor is being garbage-collected.
Contributor
Author
There was a problem hiding this comment.
Went with the simpler solution, just remove this is_closed check.
795311f to
c0eaac1
Compare
sophia-bq
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, MySQL would sometimes hang because we use the executor when we call the
is_closedmethod when we call the destructor of AwsConnectionWrapper. However, when we call the destructor, it's not guaranteed.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.