Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Added 'Master Script' base JSON DB #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2021
Merged

Added 'Master Script' base JSON DB #963

merged 1 commit into from
May 1, 2021

Conversation

XZANATOL
Copy link
Contributor

Description

First PR Considering Master Script project, which is a menu-driven script that creates a user-friendly interface that helps navigating in the repo. Added the JSON file DB

Fixes issue #831

(didn't correctly link it, to not automatically close the issue)

Notes

  1. Not all projects are added, some are yet still under discussion on how it should be implemented. - refer to this comment -
  2. It will be appreciated that the next contributor updates the DB while doing his part as the repo adds new projects almost daily.

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@XZANATOL
Copy link
Contributor Author

@kaustubhgupta updates?

@kaustubhgupta
Copy link
Contributor

@kaustubhgupta updates?

Hi, @XZANATOL I will review it in the afternoon as this is a big issue and I think that your script will make the pull request automation too. I will try to update you today

kaustubhgupta
kaustubhgupta approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works Good! Now I think we can integrate the Pull request automation to add the projects directly to this JSON based on the data parameters defined in the Pull request template. I will ping PA that no new PR should be merged until we test out this feature.

@kaustubhgupta kaustubhgupta added gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants and removed gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants labels Apr 27, 2021
@kaustubhgupta kaustubhgupta added the next review needed Approved by some mentors, more approvals needed label Apr 27, 2021
@kaustubhgupta
Copy link
Contributor

@santushtisharma10 @antrikshmisri this PR needs urgent attention and approval so that we can start working on the automation part

@kaustubhgupta kaustubhgupta added the Urgent Issues needed to be address Immediately label Apr 27, 2021
@XZANATOL
Copy link
Contributor Author

@kaustubhgupta So what is going to happen next is that we are going to import the script into a GitHub action which will get the required inputs of the database from an updated PR template. Am i correct?

@kaustubhgupta
Copy link
Contributor

@kaustubhgupta So what is going to happen next is that we are going to import the script into a GitHub action which will get the required inputs of the database from an updated PR template. Am i correct?

Yes, you are correct. I am preparing some notes for this and I will share a pseudo implementation soon on the main issue. Then you can modify the script and then we will test it on our forked repos or maybe demo repositories. If it works well then I will instruct all the participants to fix their issue descriptions and merging them will be a real test for us. I hope it goes as expected.

Kushal997-das
Kushal997-das approved these changes Apr 27, 2021
View reviewed changes
Copy link

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing and removed Urgent Issues needed to be address Immediately next review needed Approved by some mentors, more approvals needed labels Apr 27, 2021
@XZANATOL
Copy link
Contributor Author

@kaustubhgupta this is getting really interesting. :D
OK, add on these that I've a demo repo where I use to test actions, we can use it for this goal.

@kaustubhgupta kaustubhgupta added the Urgent Issues needed to be address Immediately label May 1, 2021
@kaustubhgupta kaustubhgupta merged commit df8bb61 into avinashkranjan:master May 1, 2021
@kaustubhgupta kaustubhgupta linked an issue May 8, 2021 that may be closed by this pull request
Making the Whole Project/Repo Menu-Driven #831
Open
@kaustubhgupta kaustubhgupta mentioned this pull request May 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@kaustubhgupta kaustubhgupta kaustubhgupta approved these changes

@antrikshmisri antrikshmisri antrikshmisri approved these changes

@santushtisharma10 santushtisharma10 santushtisharma10 approved these changes

@Kushal997-das Kushal997-das Kushal997-das approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing Urgent Issues needed to be address Immediately

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Making the Whole Project/Repo Menu-Driven

5 participants

@XZANATOL @kaustubhgupta @antrikshmisri @santushtisharma10 @Kushal997-das
Morty Proxy This is a proxified and sanitized view of the page, visit original site.