[BUGFIX] resolve x86 CPU Model Name Bug #1647
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re.IGNORECASEcauses a hit on the CPU model number before the CPU name (this has been edited per my most recent comment on this PR). On a 6th-gen x86 Intel CPU, the CPU ID is 94, not a CPU model string.Description
I would like to update
arm/models/system_info.pyto fix a regex issue when ARM is running in Docker on x86 CPUs. Currently, the model number is displayed instead of the CPU name (not expected behavior).Context: I was wondering why the CPU was listed as 94 instead of as a 6th gen i5.
Motivation: I realized it was a bug.
Fixes #1646 (admittedly, I also created this issue a bit ago.)
Type of change
How Has This Been Tested?
I used a python shell with the relevant cpuinfo data dumped to a text file as well as a few different regex calculators online. As this is a relatively minor change, I didn't redeploy arm to validate. I am using Docker on Debian Trixie.
Checklist:
Changelog:
Include the details of changes made here
re.IGNORECASEfrom regex in line 47 ofarm/models/system_info.pyLogs
N/A, minor bugfix