[FEATURE] Changed build base image #1604
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change base image of arm-ui devel image
Description
Changed build base image, as we don't need such a large image if we are only running one service (frontend)
- Image shrunk from 1GB -> 160MB
Removed comments from Dockerfile
- Way to many (IMHO) and was harder to read
Broke UI requirements to its own file, to help track requirements separately
- It will be easier to track, and help keeps things manageable to have separate requirements for each container
Removed comments from health check, also udev isnt needed in UI container so was removed.
- Comments didnt really help, as for the ripper we know already what needs checking for the container to work, so the comments dont help
Fixes # None
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Build, ran on docker.
Checklist:
Changelog:
Include the details of changes made here
Summary of changes
Dockerfile-UI
requirements_ui.txt (new)
Helps separate UI deps from ripper/tooling dependencies.
comments.jsonas arm now looks for it inside/arm/app/comments.jsondocker-compose.yml
temp_healthcheck.sh
Logs
Attach logs from successful test runs here