Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

DimitriPapadopoulos
Copy link
Contributor

m4/ax_cpu_freq.m4 Show resolved Hide resolved
Copy link
Collaborator

@petk petk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also serial numbers need to be updated here...

@petk
Copy link
Collaborator

petk commented May 13, 2024

Ah, I see, this last fail in the CI was only related to separate commit itself since the CI checks commits separately. Otherwise all looks ok here.

Thanks @DimitriPapadopoulos

@petk petk mentioned this pull request May 13, 2024
@DimitriPapadopoulos
Copy link
Contributor Author

Squashed into a single commit.

@spaette
Copy link

spaette commented May 28, 2024

ax_cpu_freq.m4

-     [ax_cpu_freq=unknow; rm -f conftest_cpufreq]
+     [ax_cpu_freq=unknown; rm -f conftest_cpufreq]

Was this one on purpose?

Is the string an action or the result of something?

such clarification might facilitate a decision on whether or not to modify the string

ax_dist_msi.m4

typo addind on line 56

ax_prog_emacs.m4

typo failurefully on line 25

ax_sys_perlsharpbang.m4

possibly change this comment line

# bec it must be absent in Makefile

to

# as it must not appear in Makefile

@DimitriPapadopoulos
Copy link
Contributor Author

Thank you for the review, I'll apply the suggestions next week and look into ax_cpu_freq.m4.

@DimitriPapadopoulos
Copy link
Contributor Author

ax_cpu_freq.m4

-     [ax_cpu_freq=unknow; rm -f conftest_cpufreq]
+     [ax_cpu_freq=unknown; rm -f conftest_cpufreq]

Was this one on purpose?

Is the string an action or the result of something?

such clarification might facilitate a decision on whether or not to modify the string

It's clearly a result, that is later used to define CPU_FREQ. Two issues here:

  • backwards compatibility,
  • the possibility that the result is misspelled on purpose — but I cannot imagine why.

The misspelling has been there from the start (6c640df in 2007).

ax_prog_emacs.m4

typo failurefully on line 25

I could change exit failurefully into exit in error. However, wasn't that an intentional pun?

@spaette
Copy link

spaette commented Jun 1, 2024

$ sed -n '20,24p' /tmp/autoconf-archive/m4/ax_gcc_x86_avx_xgetbv.m4
#   If the xgetbv instruction fails (because you are running a
#   cross-compiler, or because you are not using gcc, or because you are on
#   a processor that doesn't have this instruction),
#   ax_cv_gcc_x86_avx_xgetbv_OP is set to the string "unknown".
#
$ sed -n '75,77p' /tmp/autoconf-archive/m4/ax_gcc_x86_avx_xgetbv.m4
     [ax_cv_gcc_x86_avx_xgetbv_$1=`cat conftest_xgetbv`; rm -f conftest_xgetbv],
     [ax_cv_gcc_x86_avx_xgetbv_$1=unknown; rm -f conftest_xgetbv],
     [ax_cv_gcc_x86_avx_xgetbv_$1=unknown])])
$ sed -n '22,25p' /tmp/autoconf-archive/m4/ax_gcc_x86_cpuid.m4
#   If the cpuid instruction fails (because you are running a
#   cross-compiler, or because you are not using gcc, or because you are on
#   a processor that doesn't have this instruction), ax_cv_gcc_x86_cpuid_OP
#   is set to the string "unknown".
$ sed -n '85,87p' /tmp/autoconf-archive/m4/ax_gcc_x86_cpuid.m4
     [ax_cv_gcc_x86_cpuid_$1=`cat conftest_cpuid`; rm -f conftest_cpuid],
     [ax_cv_gcc_x86_cpuid_$1=unknown; rm -f conftest_cpuid],
     [ax_cv_gcc_x86_cpuid_$1=unknown])])
$ 

DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Jun 1, 2024
@spaette
Copy link

spaette commented Jun 1, 2024

@tnguyen-rh

Was the intention exit failure fully?

$ sed -n '21,25p' /tmp/autoconf-archive/m4/ax_prog_emacs.m4
#   If env var EMACS is set, try to use its value directly, but avoid
#   getting fooled by value 't' (set by older Emacsen for subprocesses). If
#   no joy from the environment, search for "emacs" via AC_CHECK_PROG. If
#   still no joy, display "Emacs not found; required!" and make configure
#   exit failurefully. Otherwise, set shell var EMACS and AC_SUBST it, too.
$ 

@spaette
Copy link

spaette commented Jun 1, 2024

@stevengj

I guess you are one of the listed authors of ax_gcc_x86_avx_xgetbv.m4.

Would you have additional explanation of the code in ax_cpu_freq.m4?

DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Jun 2, 2024
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Jun 2, 2024
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Jun 4, 2024
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Jun 4, 2024
@peti peti merged commit 6364d90 into autoconf-archive:master Oct 16, 2024
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch October 16, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.