Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tsibley/python-astm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
Loading
...
head repository: aucan/python-astm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Loading
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 9 files changed
  • 1 contributor

Commits on Feb 26, 2020

  1. Support slices of RepeatedComponentFields

    Fixes a failing test in astm/tests/test_mapping.py (test_proxy_slices).
    
    At least as of Python 3.6, slice operations end up calling __getitem__
    and __setitem__ with a slice object instead of the deprecated
    __getslice__ and __setslice__.
    tsibley committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    0a339f2 View commit details
    Browse the repository at this point in the history
  2. Tests: Removed unused "sampled_at" field from Order response data

    The server's Order model does not use that field (but the client does).
    
    I assume the test is wrong rather than the model, but if not, then the
    field could be added to the model instead.  Not clear to me from VCS
    history what the intent was, though.
    
    Fixes the failing test.
    tsibley committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    3c55e05 View commit details
    Browse the repository at this point in the history
  3. Address all warnings on Python 3.6 that are emitted by tests

    Mostly unrecognized escape sequences because of bare backslashes.
    
    Tests are now free of warnings on 3.6.  There may be other warnings
    produced by the library if the code isn't covered by tests, but those
    can be fixed as they're uncovered.
    tsibley committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    7a7658e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b36bdaa View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Address warning on Python 3.8

    tsibley committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    c2fb045 View commit details
    Browse the repository at this point in the history
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.