Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

amurdock
Copy link

@amurdock amurdock commented Sep 6, 2017

affects: lerna-semantic-release-get-last-release, lerna-semantic-release-io

Fix versioning private modules with minor and patch values.

affects: lerna-semantic-release-get-last-release, lerna-semantic-release-io

Fix versioning private modules with minor and patch values.
affects: lerna-semantic-release-io
@amurdock
Copy link
Author

amurdock commented Sep 6, 2017

Currently when you're trying to version a private module the implementation always defaults to an initial release. This bumps the major version of the module and doesn't tag the release.

Unfortunately there's a bug in packages/lerna-sematic-release-io/io/git.js in that clients of revParse pass the version they're interested in however the implementation doesn't pass this onto simple-git.

Finally simple-git accepts a collection of versions and returns them as a \n delimited set of hashes ... however lerna-semantic-release-get-last-release expects the one and only hash it's interest in. A simple .split('\n')[0] sorts this.

@KingScooty
Copy link

When is this getting merged in? I was just about to use this tool on a private module, but i might need to hold off if this isn't getting merged in any time soon.

dmiller9911 added a commit to dmiller9911/patternfly-react that referenced this pull request Jun 20, 2018
Publish react-docs to avoid versioning with every change this is a workaround for the pr here: atlassian/lerna-semantic-release#86

affects: @patternfly/react-docs
jeff-phillips-18 pushed a commit to patternfly/patternfly-react that referenced this pull request Jun 20, 2018
Publish react-docs to avoid versioning with every change this is a workaround for the pr here: atlassian/lerna-semantic-release#86

affects: @patternfly/react-docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.