Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7b7b105

Browse filesBrowse files
committed
Merge pull request revel#765 from revel/revert-690-graceful-restarts
Revert "Support zero downtime restarts"
2 parents e65023b + 5b9b519 commit 7b7b105
Copy full SHA for 7b7b105

File tree

Expand file treeCollapse file tree

1 file changed

+6
-39
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-39
lines changed

‎server.go

Copy file name to clipboardExpand all lines: server.go
+6-39Lines changed: 6 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package revel
33
import (
44
"code.google.com/p/go.net/websocket"
55
"fmt"
6-
"github.com/rcrowley/goagain"
76
"io"
87
"net"
98
"net/http"
@@ -111,46 +110,14 @@ func Run(port int) {
111110
// to terminate SSL upstream when using unix domain sockets.
112111
ERROR.Fatalln("SSL is only supported for TCP sockets. Specify a port to listen on.")
113112
}
114-
ERROR.Fatalln("Failed to listen:", Server.ListenAndServeTLS(HttpSslCert, HttpSslKey))
115-
} else if Config.BoolDefault("graceful", false) {
116-
serveGraceful(network, localAddress)
113+
ERROR.Fatalln("Failed to listen:",
114+
Server.ListenAndServeTLS(HttpSslCert, HttpSslKey))
117115
} else {
118-
ERROR.Fatalln("Failed to serve:", Server.Serve(listen(network, localAddress)))
119-
}
120-
}
121-
122-
func listen(network, localAddress string) net.Listener {
123-
listener, err := net.Listen(network, localAddress)
124-
if err != nil {
125-
ERROR.Fatalln("Failed to listen:", err)
126-
}
127-
return listener
128-
}
129-
130-
func serveGraceful(network, localAddress string) {
131-
listener, err := goagain.Listener()
132-
133-
if err != nil {
134-
// New process, create the listener.
135-
listener = listen(network, localAddress)
136-
go Server.Serve(listener)
137-
} else {
138-
// Forked child, recover the listener.
139-
INFO.Println("Resuming listening on", listener.Addr())
140-
go Server.Serve(listener)
141-
142-
// Child is ready to accept connections, kill parent process.
143-
if err := goagain.Kill(); err != nil {
144-
ERROR.Println("Failed to kill parent:", err)
116+
listener, err := net.Listen(network, localAddress)
117+
if err != nil {
118+
ERROR.Fatalln("Failed to listen:", err)
145119
}
146-
}
147-
148-
if _, err := goagain.Wait(listener); err != nil {
149-
ERROR.Fatalln("Failed to serve:", err)
150-
}
151-
152-
if err := listener.Close(); err != nil {
153-
ERROR.Fatalln("Failed to close listener:", err)
120+
ERROR.Fatalln("Failed to serve:", Server.Serve(listener))
154121
}
155122
}
156123

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.