Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 159792c

Browse filesBrowse files
Merge branch 'develop' into feature/contribution-guide-fix
2 parents baa5f05 + c0220f9 commit 159792c
Copy full SHA for 159792c

File tree

Expand file treeCollapse file tree

3 files changed

+15
-16
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+15
-16
lines changed

‎.travis.yml

Copy file name to clipboardExpand all lines: .travis.yml
+2-10Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ install:
3838
- git clone -b $REVEL_BRANCH git://github.com/revel/cmd ../cmd/
3939
- git clone -b $REVEL_BRANCH git://github.com/revel/config ../config/
4040
- git clone -b $REVEL_BRANCH git://github.com/revel/cron ../cron/
41-
- git clone -b $REVEL_BRANCH git://github.com/revel/samples ../samples/
41+
- git clone -b $REVEL_BRANCH git://github.com/revel/examples ../examples/
4242
- go get -v github.com/revel/revel/...
4343
- go get -v github.com/revel/cmd/revel
4444

@@ -55,18 +55,10 @@ script:
5555
- revel package my/testapp
5656
- revel package my/testapp prod
5757

58-
# Build & run the sample apps
59-
- revel test github.com/revel/samples/booking
60-
- revel test github.com/revel/samples/chat
61-
- revel test github.com/revel/samples/facebook-oauth2
62-
- revel test github.com/revel/samples/twitter-oauth
63-
- revel test github.com/revel/samples/validation
64-
- revel test github.com/revel/samples/upload
65-
6658
# Commented out persona test sample, since persona.org gonna be shutdown.
6759
# Also http://personatestuser.org becomes non-responsive most of the time.
6860
# https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers
69-
# - revel test github.com/revel/samples/persona
61+
# - revel test github.com/revel/examples/persona
7062

7163
matrix:
7264
allow_failures:

‎errors.go

Copy file name to clipboardExpand all lines: errors.go
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ type SourceLine struct {
3636
func NewErrorFromPanic(err interface{}) *Error {
3737

3838
// Parse the filename and line from the originating line of app code.
39-
// /Users/robfig/code/gocode/src/revel/samples/booking/app/controllers/hotels.go:191 (0x44735)
39+
// /Users/robfig/code/gocode/src/revel/examples/booking/app/controllers/hotels.go:191 (0x44735)
4040
stack := string(debug.Stack())
4141
frame, basePath := findRelevantStackFrame(stack)
4242
if frame == -1 {

‎params.go

Copy file name to clipboardExpand all lines: params.go
+12-5Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (c) 2012-2016 The Revel Framework Authors, All rights reserved.
1+
// Copyright (c) 2012-2017 The Revel Framework Authors, All rights reserved.
22
// Revel Framework source code and usage is governed by a MIT style
33
// license that can be found in the LICENSE file.
44

@@ -97,20 +97,27 @@ func (p *Params) calcValues() url.Values {
9797
return p.Form
9898
}
9999

100-
// Copy everything into the same map.
100+
// Copy everything into a param map,
101+
// order of priority is least to most trusted
101102
values := make(url.Values, numParams)
102-
for k, v := range p.Fixed {
103+
104+
// ?query vars first
105+
for k, v := range p.Query {
103106
values[k] = append(values[k], v...)
104107
}
105-
for k, v := range p.Query {
108+
// form vars overwrite
109+
for k, v := range p.Form {
106110
values[k] = append(values[k], v...)
107111
}
112+
// :/path vars overwrite
108113
for k, v := range p.Route {
109114
values[k] = append(values[k], v...)
110115
}
111-
for k, v := range p.Form {
116+
// fixed vars overwrite
117+
for k, v := range p.Fixed {
112118
values[k] = append(values[k], v...)
113119
}
120+
114121
return values
115122
}
116123

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.