af: skip preamble lines when parsing astro CLI table output#213
Merged
af: skip preamble lines when parsing astro CLI table output#213
Conversation
When ASTRO_API_TOKEN is set, astro CLI prepends "Using an Astro API Token" to stdout (cmd/cloud/setup.go:362). The af table parser was treating that line as the header row, collapsing the table to a single column and dropping every deployment - discover would silently report "No instances discovered" with no error. Walk lines from the top and pick the first one that boundary-detects to 2+ columns as the real header. Real headers always have multiple 2-space gaps; preamble lines have only single-space gaps and yield 1 boundary.
milton-li
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ASTRO_API_TOKENis set in the env, astro CLI prependsUsing an Astro API Tokento stdout (seeastro-clicmd/cloud/setup.go:362). The af table parser was treating that line as the header row, collapsing the deployment table to a single column calledusing_an_astro_api_token, so every row was dropped silently andaf instance discoverreportedNo instances discoveredwith no error.linesfrom the top and pick the first line that boundary-detects to 2+ columns as the real header. A real multi-column header always has 2-space gaps and yields 2+ boundaries; preamble lines have only single-space gaps and yield 1.astro deployment list --jsonwould also fix this, but it was only added in astro CLI v1.42.0 (#2063), so falling back across older versions still requires this parser to be robust.Test plan
Using an Astro API Tokenpreamble caseno Deployments found in workspace X) - returns[]cleanlytests/test_astro_cli.py+tests/test_discovery.pygreen (76/76)🤖 Generated with Claude Code
Co-authored-by: Claude Opus 4.7 (1M context) noreply@anthropic.com