Fixing numpy compatibility #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0040f37 to
60be9d6
Compare
… in python3.7 testing with this PR
60be9d6 to
30d604f
Compare
Member
Author
|
The python3.7 testing cannot be opted in here as this PR is not yet sklearn 0.20 compatible and binaries for the earlier versions are not available and the build fails for some reason on travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the numpy incompatibility issue surfaced by the tests.
Tests with newer python and numpy run locally (when tried on top of the fixes from #125), but there may still be some issues when backporting to 0.3.1